Skip to content
Failed

Changes

Summary

  1. Refactor controllers and services for consistency (commit: 355340e) (details)
Commit 355340e2e0275bfdea724686e7cd4529b0a5f3c8 by juslopezg
Refactor controllers and services for consistency

Unify controller patterns and improve service logic: controllers now use ResponseEntity<Object>, consistent error payloads (ERR_MSG constant), proper HTTP statuses, and improved exception handling. Replaced manual collection builds with stream().toList() for immutability. Aligned service method names and usages (e.g. createAdoptionTracking, createDevolution), added/updated DTO constructors and toEntity mappings (VaccineDTO, Review, Notification, etc.), removed unused imports and unused Lombok annotations from entities, and improved AdopterService validations/logging with constants and lazy self-injection. AdoptionRequestService was refactored to use orElseThrow and transactional readOnly for reads. Overall changes target code quality, SonarQube fixes, and more consistent API behavior.
(commit: 355340e)
The file was modifiedsrc/main/java/co/edu/udistrital/mdp/pets/controllers/AdoptionTrackingController.java (diff)
The file was modifiedsrc/main/java/co/edu/udistrital/mdp/pets/dto/TrialStayDetailDTO.java (diff)
The file was modifiedsrc/main/java/co/edu/udistrital/mdp/pets/controllers/ReportController.java (diff)
The file was modifiedsrc/main/java/co/edu/udistrital/mdp/pets/controllers/ReviewController.java (diff)
The file was modifiedsrc/main/java/co/edu/udistrital/mdp/pets/dto/VaccineDTO.java (diff)
The file was modifiedsrc/main/java/co/edu/udistrital/mdp/pets/services/AdoptionTrackingService.java (diff)
The file was modifiedsrc/main/java/co/edu/udistrital/mdp/pets/controllers/VaccineController.java (diff)
The file was modifiedsrc/main/java/co/edu/udistrital/mdp/pets/entities/UserEntity.java (diff)
The file was modifiedsrc/main/java/co/edu/udistrital/mdp/pets/controllers/TrialStayController.java (diff)
The file was modifiedsrc/main/java/co/edu/udistrital/mdp/pets/services/MessageService.java (diff)
The file was modifiedsrc/main/java/co/edu/udistrital/mdp/pets/controllers/DevolutionController.java (diff)
The file was modifiedsrc/main/java/co/edu/udistrital/mdp/pets/services/PetService.java (diff)
The file was modifiedsrc/main/java/co/edu/udistrital/mdp/pets/services/ShelterEventService.java (diff)
The file was modifiedsrc/main/java/co/edu/udistrital/mdp/pets/services/VaccineService.java (diff)
The file was modifiedsrc/main/java/co/edu/udistrital/mdp/pets/controllers/AdoptionController.java (diff)
The file was modifiedsrc/main/java/co/edu/udistrital/mdp/pets/services/ReviewService.java (diff)
The file was modifiedsrc/main/java/co/edu/udistrital/mdp/pets/controllers/AdoptionHistoryController.java (diff)
The file was modifiedsrc/main/java/co/edu/udistrital/mdp/pets/controllers/MessageController.java (diff)
The file was modifiedsrc/main/java/co/edu/udistrital/mdp/pets/controllers/ShelterController.java (diff)
The file was modifiedsrc/main/java/co/edu/udistrital/mdp/pets/controllers/VeterinarianController.java (diff)
The file was modifiedsrc/main/java/co/edu/udistrital/mdp/pets/services/VeterinarianService.java (diff)
The file was modifiedsrc/main/java/co/edu/udistrital/mdp/pets/entities/NotificationEntity.java (diff)
The file was modifiedsrc/main/java/co/edu/udistrital/mdp/pets/services/ShelterService.java (diff)
The file was modifiedsrc/main/java/co/edu/udistrital/mdp/pets/controllers/ShelterEventController.java (diff)
The file was modifiedsrc/main/java/co/edu/udistrital/mdp/pets/services/AdopterService.java (diff)
The file was modifiedsrc/main/java/co/edu/udistrital/mdp/pets/services/TrialStayService.java (diff)
The file was modifiedsrc/main/java/co/edu/udistrital/mdp/pets/dto/AdopterDetailDTO.java (diff)
The file was modifiedsrc/main/java/co/edu/udistrital/mdp/pets/services/DevolutionService.java (diff)
The file was modifiedsrc/main/java/co/edu/udistrital/mdp/pets/services/AdoptionService.java (diff)
The file was modifiedsrc/main/java/co/edu/udistrital/mdp/pets/services/AdoptionRequestService.java (diff)
The file was modifiedsrc/main/java/co/edu/udistrital/mdp/pets/services/VaccinationRecordService.java (diff)
The file was modifiedsrc/main/java/co/edu/udistrital/mdp/pets/controllers/NotificationController.java (diff)
The file was modifiedsrc/main/java/co/edu/udistrital/mdp/pets/entities/AdoptionHistoryEntity.java (diff)
The file was modifiedsrc/main/java/co/edu/udistrital/mdp/pets/services/NotificationService.java (diff)